Skip to content

Expand scanning menu for full switch control - #760

Merged
enaboapps merged 4 commits into
mainfrom
feature/full-scan-menu-759
Sep 14, 2026
Merged

enaboapps merged 4 commits into
mainfrom
feature/full-scan-menu-759

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Point scanning now exposes grouped mouse, editing, apps/windows, browser, media, display and scanning controls through More after point selection. The original click, scroll and drag actions remain on the first page. All menus use up to three columns and nine tiles, with a navigation stack that restores the parent selection and interval. Typing and power controls are excluded.

Desktop actions preserve foreground focus. Injected shortcuts carry a scanner bypass marker, and failed releases retain ownership for cleanup. Scan settings persist through the existing configuration; display and mode changes start a fresh point scan. Pause resumes on Select without activating a tile. Action failures remain visible until acknowledged with Select. Mac Close window presses the focused window’s native close button, preserving native save handling and keeping it distinct from Close tab. Long native labels and return prompts wrap. Each new action and group now has bespoke vector artwork, including modifier clicks, tabs, media controls and scan settings. A rendered set of 71 distinct symbols covers both new artwork and retained main-menu icons.

Closes #759 — milestone v1.0.0-rc.9; branched from main.

Validation:

  • All latest-head CI checks pass, including macOS app/DMG and Windows NSIS/UIAccess packaging.
  • Frontend lint/build and 152 tests passed. Rust format, clippy, 352 unit tests and 7 configuration tests passed locally.
  • Automated coverage includes menu reachability and tile limits, nested Back, scan timing/direction and pause, small-screen placement, display cycling, platform shortcut mappings, exactly-once fake input and retained cleanup after failures.
  • Independent review of latest head 3558590 found no actionable issues.
  • Icon follow-up: rendered 71 distinct symbols and inspected the actual Mac native Editing menu; scanner colour, selected fill, stroke weight and label spacing remain consistent. Restored VM settings and its original suspended state after validation.
  • Mac VM: native labels and grouped navigation, TextEdit Select all with foreground focus preserved, native Close window, Back, pause/resume, persisted auto-rate change, and single-display error with Select returning to the menu.
  • Windows 11 ARM VM: native menu at 1024×768, Notepad Select all, repeated media menu use, and native maximize. A assigned to Next remained usable while generated Ctrl+A executed without recursively starting scanning; genuine switch input started the following scan.
  • Both VM configurations restored after testing. The signed host Mac application was not replaced, launched, stopped, or modified.
  • Physical multi-display switching was covered with fake display geometry; the VMs each expose one display. No live Remote/BLE pairing was available for this check; the shared workflow and unchanged protocol remain covered by automated tests.

Merge and release require separate instructions.

Owen McGirr added 3 commits September 14, 2026 11:33
- Add mouse, editing, window, browser, media, display and scanning submenus with contextual Back navigation.
- Execute typed actions without changing foreground focus, retain failed key releases, and filter tagged injected input.
- Persist scan adjustments and return recoverable action failures through the overlay.
- Add fake-input, menu navigation, rate and display regression tests.

🤖 Auto-generated
- Keep Close window distinct from Close tab in tabbed applications
- Preserve native save prompts and report inaccessible close buttons
- Verify the window adapter executes exactly once without pointer or keyboard injection

🤖 Auto-generated
- Keep long action names readable within the three-column menu
- Render multiline Windows error prompts with room for the switch return instruction

🤖 Auto-generated
@enaboapps
enaboapps marked this pull request as ready for review September 14, 2026 11:05
- Replace generic menu placeholders with distinct vector symbols for all action groups and commands
- Keep scanner colour, selected fill and native scaling consistent with the existing tiles
- Render the complete icon set in regression coverage and reject duplicate artwork

🤖 Auto-generated
@enaboapps
enaboapps merged commit 2342247 into main Sep 14, 2026
6 checks passed
@enaboapps
enaboapps deleted the feature/full-scan-menu-759 branch September 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand scanning menu for full switch control

1 participant