Repository navigation
CI: keep the matrix check names when skipping native builds - #1089
Merged
Merged
Conversation
Skipping the native job at job level reported one "native" check, but branch protection requires "native (windows-latest, nsis)" and "native (macos-14, app,dmg)", so docs-only pull requests stayed blocked. The matrix jobs now always run and every step carries the docs-only condition instead, so they finish in about a minute under the required names. Closes #1088 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1088
#1087 skipped the
nativejob at job level for docs-only changes. That reported a single skipped check namednative, but branch protection requires the matrix-expanded namesnative (windows-latest, nsis)andnative (macos-14, app,dmg), so #1085 (docs-only) stayed blocked even though everything else passed.Now the matrix jobs always run and every step carries
if: needs.changes.outputs.app == 'true'(combined with the existingrunner.os,failure()andalways()conditions). For a docs-only change each job starts a runner, skips all 25 steps, and reports success under the required name in about a minute. App changes run exactly as before. Generated mechanically; the diff is onlyif:lines plus the comment.Validation
🤖 Generated with Claude Code