Repository navigation
Keep all component CSS in its layer; full-width pending sign-in - #1002
Merged
Merged
Conversation
The brace closing @layer components sat mid-file, so every rule after it was unlayered and outranked layered rules regardless of specificity. As a result the forced-colours rule greying aria-disabled buttons never applied (they rendered as ButtonText in High Contrast). Close the layer at the end of the file, labelled, and place the forced-colours aria-disabled rule after the rule it overrides with a matching selector. Normal rendering is unchanged. On wide windows the pending sign-in step (band and code form only) now uses a single full-width column instead of leaving the right half empty. Fixes #1001 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Address review: now that the aria-disabled rule is layered, the more specific .btn.secondary.danger:hover won while hovering a busy Delete account button. Add a :hover form of the aria-disabled rule so it outranks variant hover rules. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Address re-review: the :hover form of the aria-disabled rule outranked the forced-colours GrayText rule while hovering. Give the forced-colours rule a matching :hover form so it ties and wins by order in both states. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1001
What
Layer scope: the brace closing
@layer components {(opened near the top ofsrc/ui/app.css) sat after the max-height media query, unlabelled. Everything appended after it was unlayered: thearia-disabledbutton styles, the sidebar account entry, the Account page, and the wide-window layout. Unlayered CSS outranks layered CSS regardless of specificity. The layer now closes at the end of the file, labelled/* end @layer components */.High Contrast fix: the forced-colours rule that greys
aria-disabledbuttons was less specific than the normalaria-disabledrule, so it never applied. It now sits right after that rule, with the same selector.Pending sign-in: on wide windows, the step that waits for a code (band and code form only) uses one full-width column instead of leaving the right half empty.
Review fix (hover): the newly layered
aria-disabledrule was outranked by.btn.secondary.danger:hover(0,4,0), so hovering a busy Delete account… showed the hover background. A:hoverform of the rule now outranks variant hover rules. A hover probe on asecondary dangeraria-disabledbutton shows the same disabled background idle and hovered.Review fix (forced-colours hover): the forced-colours GrayText rule gains the same
:hoverform, so it ties with the normal rule and wins by order. A probe with forced colours off and on shows identical idle and hover colours: disabled grey normally, GrayText in High Contrast.Validation
npm run lint,npm test(290 passed) andnpm run build. The CSS brace structure was checked with a script: the layer closes on the last line, with nothing unmatched.aria-disabledbutton:maingivesrgb(255, 255, 255)(ButtonText), and this branch givesrgb(63, 242, 63)(GrayText). In the light palette, GrayText renders dark red, as seen in the forced-colours screenshot.🤖 Generated with Claude Code