Skip to content

Fix query crash in .fill #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tzwaan wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix query crash in .fill #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions allscripts(deprecated).js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@ register('fill', function (pat) {
// Find the next onset, to use as an offset
const next = onsets.find(onset => onset.gte(hap.whole.end));

// If there is no next onset, the query window is not large enough.
// We bail out to avoid a crash.
if (next === undefined) {
continue;
}

// Ignore if the part ended before the original query, and hasn't expanded inside
if (next.lte(state.span.begin)) {
continue;
Expand Down
6 changes: 6 additions & 0 deletions prebake.strudel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,12 @@ register('fill', function (pat) {
// Find the next onset, to use as an offset
const next = onsets.find(onset => onset.gte(hap.whole.end));

// If there is no next onset, the query window is not large enough.
// We bail out to avoid a crash.
if (next === undefined) {
continue;
}

// Ignore if the part ended before the original query, and hasn't expanded inside
if (next.lte(state.span.begin)) {
continue;
Expand Down