a deploy must not break tabs that are already open - #21
Merged
Merged
Conversation
… can't pull the chunks out from under an open tab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone on Firefox got this after one of today's deploys:
A tab that was open before the deploy still had the old chunk names, GitHub Pages had already replaced the files, and the service worker had nothing to fall back to. Any navigation inside the app after a deploy could hit it.
What changed
Tested on the built site: 40 files precached, the editor loads and compiles with every chunk deleted from the server, fresh tabs compile through the worker as before.