[Markup] add support for swift-cmark's inline attributes#60173
Merged
Conversation
the older names were kept in the cmark header for compatibility, but these are the ones that are actually defined in the main enum
rdar://96830173
Contributor
Author
|
@swift-ci Please test |
bitjammer
requested changes
Jul 21, 2022
Contributor
bitjammer
left a comment
bitjammer
left a comment
There was a problem hiding this comment.
Just fantastic. I only have one suggestion for the name of the element to make it a little easier to navigate to in the future.
Contributor
Author
|
@swift-ci Please test |
bitjammer
approved these changes
Jul 22, 2022
Contributor
Author
|
@swift-ci Please test |
bitjammer
reviewed
Jul 22, 2022
| <param name="pattern">.*\S.*</param> | ||
| </data> | ||
| </element> | ||
| <element name="Attribute"> |
Contributor
There was a problem hiding this comment.
Sorry I missed this. It looks like you forgot to update the schema and XML printing.
Contributor
Author
|
@swift-ci Please test |
bitjammer
approved these changes
Jul 22, 2022
Contributor
bitjammer
left a comment
bitjammer
left a comment
There was a problem hiding this comment.
Thank you, everything looks great.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rdar://96830173
When the swift-cmark branch was changes from
maintogfmin #40188, swiftMarkup was not updated to handle the new kinds of nodes that were introduced. This causes the compiler to crash when using swift-cmark's "inline attributes" (or Foundation's attributed strings, which use the same syntax). This PR updates swiftMarkup to handle inline attributes from swift-cmark.