disable MSVC warning C5105#42
Merged
Merged
Conversation
on Windows SDK version 10.0.17763.0, the SDK headers spuriously trip this warning. since swift-cmark itself doesn't emit this warning on its own, diabling this warning will allow it to be built with this SDK.
Author
|
cc @compnerd this is the issue i pinged you about this morning |
compnerd
approved these changes
Mar 18, 2022
Member
compnerd
left a comment
compnerd
left a comment
There was a problem hiding this comment.
Seems like a reasonable way to handle it if it resolves the issue.
Author
|
It seems to have solved it. I added this commit to the branch being built by swiftlang/swift#40188 and the Windows test finally passed (though the toolchain is failing for unrelated reasons that you've already caught). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows SDK version 10.0.17763.0, the SDK headers spuriously trip this warning. since swift-cmark itself doesn't emit this warning on its own, disabling this warning will allow it to be built with this SDK (which is the currently active Windows SDK in Swift CI).