Skip to content

Adopt final element and request context from swift-http-api-proposal 0.1.0#89

Open
guoye-zhang wants to merge 4 commits into
swift-server:mainfrom
guoye-zhang:final-element
Open

Adopt final element and request context from swift-http-api-proposal 0.1.0#89
guoye-zhang wants to merge 4 commits into
swift-server:mainfrom
guoye-zhang:final-element

Conversation

@guoye-zhang

Copy link
Copy Markdown

No description provided.

Comment thread Package.swift
.package(
url: "https://github.com/apple/swift-http-api-proposal.git",
revision: "d58fd6fa157e08bff44aa360ff83ebd424783392"
revision: "c12fdd4c48953a691b1ce52357101e844e5f0887"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we safe to point at 0.1.0? Or should we continue to update the revision pin like this?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried but Swift doesn't allow it since swift-http-api-proposal still uses commit hashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants