Locate the lock helper by build layout and clear the style residue - #21
Merged
Merged
Conversation
The macOS leg builds through Swift Build, which writes products to .build/out/Products/Debug rather than the SwiftPM-native .build/<triple>/debug the Kernel.Lock integration suite hard-coded, so every contention test failed to spawn the helper. Probe each known product directory instead of one layout. Also apply the central swift-format rule set and replace the six force tries in the completion tests with throwing test functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Kernel.Lock Integrationprobes every known product directory for the_Lock Test Processhelper instead of the hard-coded.build/<triple>/<config>path.try!sites in the completion tests becometryin throwing test functions.Why
main is red on three independent classes:
Kernel.Lock Integrationtests fail withThe file "_Lock Test Process" doesn't exist. The helper is built; the macOS leg runs through Swift Build, which writes it to.build/out/Products/Debug, while the suite looked only in.build/arm64-apple-macosx/debug. The lookup now triesBUILT_PRODUCTS_DIR, the Swift Build layout, and the SwiftPM-native layouts in turn.force_tryfindings.No product behaviour changes.