SocketPool+ePoll: retry epoll_wait on EINTR#223
Open
lhoward wants to merge 1 commit into
Open
Conversation
epoll_wait returning -1/EINTR means a signal was delivered mid-wait; it is not an error. Treating it as fatal meant any signal (a debugger or strace attach, a timer, SIGCHLD, ...) tore down the whole server with "epoll wait: Interrupted system call". Retry the wait on EINTR instead. errno / EINTR come from libc, which this file did not import (CSystemLinux only exports the epoll/eventfd headers), so import it alongside.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #223 +/- ##
=======================================
Coverage 92.92% 92.92%
=======================================
Files 71 71
Lines 3719 3719
=======================================
Hits 3456 3456
Misses 263 263 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
epoll_wait returning -1/EINTR means a signal was delivered mid-wait; it is not an error. Treating it as fatal means any signal delivered to the process (attaching a debugger/strace, a timer, SIGCHLD, ...) tears down the whole server with
epoll wait: Interrupted system call.Retry the wait on EINTR instead.
errno/EINTRcome from libc, which this file did not import (CSystemLinux only exports the epoll/eventfd headers), so import it alongside — matching the pattern already used inSocket.swift/SocketError.swift.