a11y: adopt pa11y wcag2aaa preset#55
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches the standard of Pa11y we follow from WCAG2AA to WCAG2AAA. In general, I only aim for AA criteria, but for the rules that can be checked automatically, I'd like to strive for AAA as well.
Most of the issues reported by Pa11y were color contrast issues on light mode.
Changes
In the screenshots above, the differences probably look pretty subtle. However, when actually using the site it's more apparent.
Chores
Color Model
While doing this, I also migrated most colors from hex to HSL. During development, I always use HSL anyway, I just persisted them as hex out of habit. However, HSL is much more intuitive to work with, and the colors are replaced with hex during the build anyway.
!importantWhen overriding a CSS variable from a theme/plugin, I'm just defaulting to use
!importantnow.Historically, I only ever used
!importantwhen it seemed necessary, but now I find it be simpler when working with third-party variables.Related