fix: self position skill on MuHelper

[eduardosmaniotto]

Fix skills like Hellfire and Inferno that were not working when configured in MuHelper.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where specific area-of-effect skills were failing to activate in MuHelper because they were incorrectly requiring a target character. By introducing a mechanism to classify and handle 'self-position' skills, the changes ensure these abilities can be used correctly regardless of the current target state, improving the overall reliability of automated combat.

Highlights

• Self-Position Skill Support: Added logic to identify and handle skills that target the player's own position (e.g., Hellfire, Inferno, Nova) within the MuHelper system.
• Targeting Logic Refinement: Updated the skill execution flow to allow self-position skills to function even when no specific target is selected, while maintaining validation for existing targets.
• Distance Calculation Update: Optimized distance calculation in ComputeDistanceFromTarget to use current and next position data more effectively.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces support for self-positioning skills (such as Nova and Hellfire) in the MUHelper, refactors distance calculation logic, and ensures proper target deletion when skills fail. The review identified an opportunity to improve the robustness and efficiency of the self-position skill validation logic by reusing existing character indices and ensuring consistent target deletion for invalid targets.