Enabling warning redirection for ALARAJOYWrapper#280
Open
eitan-weinstein wants to merge 2 commits into
Open
Conversation
eitan-weinstein
added this to the
Complete pipeline for the inclusion of new data libraries milestone
Member
|
Maybe take a look at the pythons |
eitan-weinstein
force-pushed
the
warning_redirection
branch
from
401b5b1 to
6269169
Compare
eitan-weinstein
commented
May 29, 2026
| # Run NJOY | ||
| result = subprocess.run(['njoy'], input=open(INPUT).read(), | ||
| text=True, capture_output=True) | ||
| with open(INPUT, 'r') as f: |
Contributor
Author
There was a problem hiding this comment.
The logger was capturing a ResourceWarning from the previous way we were opening the input, so this change is simply to done to resolve that because it was unnecessary to have in the first place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a small update to ALARAJOYWrapper to allow the user to redirect non-fatal warnings to a log file to avoid cluttering the terminal printouts.