Fixing p0 and d0 reaction filtering in ALARAJOYWrapper#274
Closed
eitan-weinstein wants to merge 5 commits into
Closed
Fixing p0 and d0 reaction filtering in ALARAJOYWrapper#274eitan-weinstein wants to merge 5 commits into
eitan-weinstein wants to merge 5 commits into
Conversation
eitan-weinstein
added this to the
Complete pipeline for the inclusion of new data libraries milestone
Member
|
I expect this to be a small patch, but it appears to include a lot of other code... |
Contributor
Author
Oh, I think I built this branch from #271, but this should be independent of that. I'll open a new PR with the minimal fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, in #229, I must have accidentally not included MT 600 and 650 in the
EXCITATION_DICTused for filtering duplicate excitation reaction pathways if the cumulative reactions are present as well. I noticed this problem because I was seeing an unreasonably high amount of 14C production from the simulated irradiation of nitrogen, caused by the 14N (n,p) 14C reaction. Upon looking to my DSV file, I saw duplicates of both the70140 60140 pand70140 60130 dreactions, explaining the overproduction. As it stood,EXCITATION_DICTdid not include the explicit (n,p0) and (n,d0) as it should have, allowing them to sneak past the filtration system initerate_MTs(). After this patch, the nitrogen reactions all look ok and I'm sure there are reactions for other elements that are affected by this.