Skip to content

Remove the duplicate e2e workflow, apply every migration in CI, add a CI badge - #1

Merged
suryakulshreshtha merged 2 commits into
mainfrom
fix/ci-green
Oct 12, 2026
Merged

suryakulshreshtha merged 2 commits into
mainfrom
fix/ci-green

Conversation

@suryakulshreshtha

Copy link
Copy Markdown
Owner
  • Delete .github/workflows/e2e.yml. It ran npm run migrate, which points at src/migrations/run.ts, and that file does not exist, so the workflow always failed. The e2e job in ci.yml already covers the same ground.
  • In ci.yml, apply every file in backend/migrations (001 and 002) instead of only 001, matching docker-compose.
  • Add a live CI badge.

Reproduced against Postgres 16: with only migration 001 applied, 2 of the 6 E2E tests fail (the ones that read seeded data) and the step exits 1; with 001 and 002 applied, all 6 pass.

The second commit pins the runner to ubuntu-24.04. GitHub has announced that the ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026 (actions/runner-images#14748). The pin keeps the image these workflows run on today, so nothing changes now. Drop that commit if you would rather follow the label.

GitHub has announced that the ubuntu-latest label will migrate to Ubuntu 26
beginning October 19, 2026 (actions/runner-images#14748). Pinning keeps the
image these workflows run on today, so nothing changes now, and moving to 26
becomes a change you make on purpose and can test.
@suryakulshreshtha
suryakulshreshtha merged commit 0710c34 into main Oct 12, 2026
3 checks passed
@suryakulshreshtha
suryakulshreshtha deleted the fix/ci-green branch October 15, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant