Remove string-prototype-matchall#60
Open
donmccurdy wants to merge 1 commit into
Open
Conversation
|
@surma Could you please merge this and publish a new version? This unnecessary dependency would significantly unbloat the dependency tree. Thanks in advance for your time! |
|
@surma Hi again, could you please take a look at this, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
string-prototype-matchall. Support forString.prototype.matchAlllanded in Node.js v12, and Node.js v16 reached EOL in September 2023, so I agree with the poster of #58 that the need for this shim is now gone. While reviewing my own package dependencies, this was a big source. Thank you!