Skip to content

Feature/90 layout of the search field–in the navbar - #97

Open
Stampoo wants to merge 3 commits into
developfrom
feature/90-Layout-of-the-search-field–in-the-navbar

Hidden character warning

The head ref may contain hidden characters: "feature/90-Layout-of-the-search-field\u2013in-the-navbar"
Open

Feature/90 layout of the search field–in the navbar#97
Stampoo wants to merge 3 commits into
developfrom
feature/90-Layout-of-the-search-field–in-the-navbar

Conversation

@Stampoo

@Stampoo Stampoo commented Apr 30, 2021

Copy link
Copy Markdown
Contributor

Description

  • Add SearchView
  • Add SearchView to main screen

How has this been tested?

Build and run)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

What to look for?

  • toolBar does't resizing subview, and subview does't filling all free space, may be replace him more comparable element?) It will save us from fixed size elements in different idioms (ToolBar set standard element width, based on height, like UIBarButtonItem, break constraint in console log confirm it theory))

Closes #90

@Stampoo Stampoo added feature New feature or request WIP Work in process labels Apr 30, 2021
@Stampoo Stampoo self-assigned this Apr 30, 2021
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.25%. Comparing base (03d12f9) to head (0cd7b96).
⚠️ Report is 20 commits behind head on develop.

Files with missing lines Patch % Lines
...eFlow/Sources/HomeFlow/SearchView/SearchView.swift 0.00% 27 Missing ⚠️
.../HomeFlow/Sources/HomeFlow/PageView/PageView.swift 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop     #97      +/-   ##
==========================================
- Coverage     4.31%   4.25%   -0.06%     
==========================================
  Files          121     122       +1     
  Lines         3543    3592      +49     
  Branches      1664    1680      +16     
==========================================
  Hits           153     153              
- Misses        3386    3435      +49     
  Partials         4       4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request WIP Work in process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[step 1] Layout of the search field in the navbar

2 participants