0.1.0: prevent release test command overrides

[suraciii]

Goal

Make every release test command fail closed.

Problem

A caller could set GO_TEST=true and replace the test command. Review also found that a caller could set MAKE=true and skip recursive CI targets. The release command could then report success without running all tests.

Scope

• Use literal internal testcheck commands in release entry points.
• Do not use a replaceable test runner or recursive Make in release entry points.
• Cover the complete dry-run plans for ci, external, and external-tagged.
• Keep all required commands in order under parallel Make.
• Keep the nonzero test-count check.

Acceptance

• GO_TEST=true does not change a release command plan.
• MAKE=true does not change a release command plan.
• ci, external, and external-tagged keep all required commands in order.
• Parallel Make does not change the command order.
• A zero-test target still fails.
• make ci and make external pass.

References

• Makefile
• design/testing.md
• design/release.md
• research/release-0.1.0-issue-111-mutation.md

[suraciii]

Local reviewed batch: bcfd56a993813a82368aa52a8b10f377e75a28ab (Prevent release command overrides).

The first design blocked GO_TEST=true. Independent review found a second bypass: MAKE=true skipped recursive CI targets. The final design uses literal go run ./internal/testcheck commands, removes recursive Make from release entry points, and keeps prerequisites serial under parallel Make. The final independent review passed with no P0-P3 findings.

Mutation proof:

• Replacing one literal test command with GO_TEST made the release contract test fail.
• Removing the release command check from external-tagged made only that plan fail.
• Restoring each mutation made the focused test pass.

Fresh proof on the exact commit:

• go clean -testcache && make ci: pass. It ran 4 release command contract tests, 604 default tests, 19 simulation tests, 19 generator tests, 45 transport network tests, 43 example network tests, 2 resource tests, and 3 fuzz targets.
• go clean -testcache && make external: pass. It ran 4 release command contract tests, 1 Quick Start test, and 19 external module and restart tests.
• The worktree is clean.

The commit is not on remote master. Keep this issue open until integration and remote proof are complete.

[suraciii]

Completed in the integrated candidate #116 and strengthened by #119. Release entry points use literal testcheck commands; GO_TEST, MAKE, parallel Make, and the former FUZZ_TIME variable cannot change or weaken the required ordered plans; zero-test targets remain failures. Exact master 0c41f9f644905183d7d4fd8f7efed24e4396bf0d passed local make external, local make ci, and hosted run https://github.com/suraciii/gor/actions/runs/31504300130.