Skip to content

diag(video): the #409 verdict line names the cadence it measured #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superuser404notfound merged 1 commit into from
Aug 25, 2026
Merged

diag(video): the #409 verdict line names the cadence it measured #428

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Sources/AetherEngine/Video/H264CompositionOffsetRepair.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,8 +729,15 @@ final class H264CompositionOffsetRepairSession {
)
switch verdict {
case .repair(let plan):
// The cadence and its phase belong in the line: on a fractional ladder they are the
// reading the verdict rests on, and a repair that reports only a rounded step cannot be
// told apart from one that measured the ladder wrong.
let cadenceDescription = plan.cadence.map {
" cadence=\($0.numerator)/\($0.denominator) phase=\(plan.ladderPhase)"
+ " ladderAhead=\(plan.ladderOrdinalOffset)"
} ?? ""
verdictDescription = "repair step=\(plan.step) lead=\(plan.decodeLead) "
+ "shift=\(plan.shift) pocStep=\(plan.pocStep)"
+ "shift=\(plan.shift) pocStep=\(plan.pocStep)" + cadenceDescription
phase = .repairing
var rewriter = H264CompositionOffsetRepair.Rewriter(plan: plan)
for entry in held where entry.packet.pointee.stream_index == streamIndex {
Expand Down
Loading