Enable ASYNC Step input snapshots by default - #509
Merged
Merged
Conversation
Keeping this history is the default Server behavior. Operators can still turn it off to skip the extra Blob Store cost.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blobStore.asyncStepInputSnapshotsEnabledback on by default when Blob Store is enabled, so semantic history keeps successful ASYNC local Step method inputs.truefor the default; setfalseto skip snapshot writes.Test plan
make -C server unitTestsEventDetailsvitestmake docs-prose-checkandcd docs && npm run checkweb_apiinteg coverage for default-on and explicit-off snapshots (CI)skill-dex-developerstays blocked until this change is in a published Dex release. SuperVerse should disable the flag in its own Dex Server configs.Made with Cursor