Add SDK and CLI server protocol compatibility checks - #481
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FlowService.GetServerInfowith diagnostic Server version and an inclusive supported protocol intervaldexcli version checkwith structured compatibility output and failure reportingRationale and user impact
Artifact versions do not reliably describe wire compatibility. Server and client protocol intervals let newer SDKs retain support for older Servers while allowing breaking Server releases to reject SDKs that no longer overlap. Servers without
GetServerInfoare rejected, so the mechanism is introduced with a Server-first upgrade.Workers now fail startup before index synchronization or listener binding when the information RPC fails, an interval is invalid, or the intervals do not overlap. Existing running Workers do not renegotiate. Operators can check CLI compatibility explicitly with
dexcli version check.Validation
UV_CACHE_DIR=/tmp/dex-uv-cache make generated-code-checkmake copyright-checkmake docs-prose-checkmake -C server unitTestsTestServerInfointegration testsactionlintfor every changed release workflowThe full local Server integration command also exercised the new tests successfully, but the aggregate run reached its 20-minute timeout after two unrelated Cadence text-search assertions returned no results. Those assertions reproduced in isolation and are outside this change's search paths.
Related
The matching dex-developer skill update is published as a separate stacked PR because it lives in another repository.