test: synchronize durable reminder E2E - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- wait for the process to reach its durable approval-wait state before skipping the reminder timer\n- assert the reminder state transition before verifying the reminder count\n\n## Root cause\nThe browser test attempted to skip the timer as soon as the create response rendered a Flow panel. That response can arrive before the worker has registered the durable timer, which made the test race CI scheduling.\n\n## Verification\n- ./scripts/with-dex.sh ./scripts/run-e2e.sh
vite v8.3.0 building client environment for production...
transforming...
✓ 29 modules transformed.
rendering chunks...
computing gzip size...
dist/index.html 0.40 kB │ gzip: 0.26 kB
dist/assets/index-BpLvuhmr.css 2.66 kB │ gzip: 1.08 kB
dist/assets/index-ElFyP-n0.js 235.21 kB │ gzip: 74.10 kB
✓ built in 72ms
Running 2 tests using 2 workers
✓ 2 e2e/basic-process.spec.ts:4:1 › runs approval automation through a durable reminder (3.3s)
1 skipped
1 passed (3.7s) (5 consecutive runs using the CI-pinned Dex baseline)\n- go mod download
go -C tools/openapi mod download
npm --prefix web ci
added 171 packages, and audited 172 packages in 1s
44 packages are looking for funding
run
npm fundfor details4 high severity vulnerabilities
To address issues that do not require attention, run:
npm audit fix
To address all issues (including breaking changes), run:
npm audit fix --force
Run
npm auditfor details../scripts/check-generated.sh
�[90m@hey-api/openapi-ts v0.99.0�[39m
�[90m[Job 1] �[39m�[90m~�[39m �[36mGenerating...�[39m
�[90m[Job 1] �[39m�[36m [1] �[39m../openapi/openapi.yaml
�[90m[Job 1] �[39m�[32m✓�[39m �[96m./../../../../var/folders/rw/byg_h4h92910100h6sx9y4x80000gn/T/dex-basic-process-codegen.0DFHVS/web�[39m �[90m· 4 files · 36ms�[39m
./scripts/check-fdg-v2.sh
Flow definition JSON: /var/folders/rw/byg_h4h92910100h6sx9y4x80000gn/T//basic-process-fdg-v2.JbwqXL.json
validated FDG 2.0 graph
go mod tidy -diff
go vet ./...
/Library/Developer/CommandLineTools/usr/bin/make test-unit
go test ./...
? github.com/superdurable/dex-template-basic-process/cmd/mock-server [no test files]
ok github.com/superdurable/dex-template-basic-process/cmd/server (cached)
? github.com/superdurable/dex-template-basic-process/internal/api [no test files]
? github.com/superdurable/dex-template-basic-process/internal/api/generated [no test files]
ok github.com/superdurable/dex-template-basic-process/internal/mockserver (cached)
ok github.com/superdurable/dex-template-basic-process/internal/process (cached)
? github.com/superdurable/dex-template-basic-process/internal/runtime [no test files]
ok github.com/superdurable/dex-template-basic-process/internal/templatecontract 0.178s
npm --prefix web test
RUN v5.0.1 /private/tmp/dex-template-ci-fix.Oq9vCi/web
Test Files 2 passed (2)
Tests 9 passed (9)
Start at 17:00:37
Duration 746ms (tests 53%, environment 32%, transform 6%, import 5%, setup 4%)
/Library/Developer/CommandLineTools/usr/bin/make test-integration
./scripts/with-dex.sh go test -tags=integration ./...
? github.com/superdurable/dex-template-basic-process/cmd/mock-server [no test files]
ok github.com/superdurable/dex-template-basic-process/cmd/server (cached)
? github.com/superdurable/dex-template-basic-process/internal/api [no test files]
? github.com/superdurable/dex-template-basic-process/internal/api/generated [no test files]
ok github.com/superdurable/dex-template-basic-process/internal/mockserver (cached)
ok github.com/superdurable/dex-template-basic-process/internal/process 1.451s
? github.com/superdurable/dex-template-basic-process/internal/runtime [no test files]
ok github.com/superdurable/dex-template-basic-process/internal/templatecontract 0.148s
/Library/Developer/CommandLineTools/usr/bin/make test-e2e
./scripts/with-dex.sh ./scripts/run-e2e.sh
vite v8.3.0 building client environment for production...
transforming...
✓ 29 modules transformed.
rendering chunks...
computing gzip size...
dist/index.html 0.40 kB │ gzip: 0.26 kB
dist/assets/index-BpLvuhmr.css 2.66 kB │ gzip: 1.08 kB
dist/assets/index-ElFyP-n0.js 235.21 kB │ gzip: 74.10 kB
✓ built in 339ms
Running 2 tests using 2 workers
✓ 2 e2e/basic-process.spec.ts:4:1 › runs approval automation through a durable reminder (2.7s)
1 skipped
1 passed (3.1s)
/Library/Developer/CommandLineTools/usr/bin/make test-mock-e2e
./scripts/run-mock-e2e.sh
Mock UI: http://127.0.0.1:55825
Running 1 test using 1 worker
✓ 1 e2e/mock-basic-process.spec.ts:5:1 › exercises the complete mock UI lifecycle and failures (5.0s)
1 passed (5.3s)
/Library/Developer/CommandLineTools/usr/bin/make build
npm --prefix web run build
vite v8.3.0 building client environment for production...
transforming...
✓ 29 modules transformed.
rendering chunks...
computing gzip size...
dist/index.html 0.40 kB │ gzip: 0.26 kB
dist/assets/index-BpLvuhmr.css 2.66 kB │ gzip: 1.08 kB
dist/assets/index-ElFyP-n0.js 235.21 kB │ gzip: 74.10 kB
✓ built in 56ms
go build -o bin/basic-process ./cmd/server