fix(super-editor): insert mentions on first click - #3879
Merged
caio-pizzol merged 4 commits intoAug 10, 2026
Conversation
Prevent mention row mousedown events from reaching the document-level selection handler, which remounted the popover before click could fire. Closes superdoc#3878
Contributor
|
Hey @malizhev, thanks for the fix! We reproduced the issue and confirmed that the implementation fixes first-click mention insertion. I pushed a small follow-up to your branch so the regression test mounts into The focused mention and popover tests are passing. Thanks again! |
caio-pizzol
enabled auto-merge (squash)
August 10, 2026 16:23
caio-pizzol
disabled auto-merge
August 10, 2026 17:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mousedown.clickhandler inserts the selected user.inserMentionprop typo toinsertMentionin the mention component and its caller.Why
Clicking a user in the mention popover currently requires two clicks. The first
mousedownreaches the document-level custom-selection handler, which reapplies the editor state. Because the popover is still marked for an update, this remountsMentions.vuebefore the browser can dispatchclickto the original row.Closes #3878