fix(python-sdk): chmod CLI binary at build time instead of runtime#3179
Open
mattConnHarbour wants to merge 1 commit intomainfrom
Open
fix(python-sdk): chmod CLI binary at build time instead of runtime#3179mattConnHarbour wants to merge 1 commit intomainfrom
mattConnHarbour wants to merge 1 commit intomainfrom
Conversation
Fixes Docker issue where root installs but non-root user runs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CLI binary shipped without execute permissions (Python wheels strip them). In Docker: root installs, non-root user tries to exec, and is denied. Runtime
os.chmod()fails for the same reason—non-root can't chmod a root-owned file.Fix
Add
setup.pybuild hooks that chmod the binary during wheel creation. Binary ships with execute permissions baked in, no runtime chmod needed.Follow-up
Platform packages are nearly identical—could be generated from
python-embedded-cli-targets.mjsinstead of maintained manually.