SD-2875 - fix: context menu not showing suggestions after typecheck#3174
Merged
chittolinag merged 4 commits intomainfrom May 6, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
caio-pizzol
approved these changes
May 5, 2026
Contributor
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
@chittolinag lgtm :)
left two optional notes inline - skip if you'd rather move on.
luccas-harbour
approved these changes
May 5, 2026
Co-authored-by: Caio Pizzol <97641911+caio-pizzol@users.noreply.github.com>
Co-authored-by: Caio Pizzol <97641911+caio-pizzol@users.noreply.github.com>
chittolinag
deleted the
gabriel/sd-2875-bug-spellcheck-suggestions-missing-from-context-menu-in-129
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
<ContextMenu>was rebound from the innerEditorto thePresentationEditorwrapper.resolveProofingContextonly looked upeditor._presentationEditor, which the wrapper doesn't have — so it returnednulland the menu dropped every suggestion.Proposed solution
resolveProofingContext(context-menu/utils.js), resolve the manager from any of the three editor handles the menu can be wired to:_presentationEditor.proofingManagerpresentationEditor.proofingManagerproofingManagerBehavior tests
tests/behavior/tests/slash-menu/proofing-context-menu.spec.ts:teh, asserts the suggestions appear and clickingtherewrites the doc.proofing-replace-*rows appear when there's no issue at the cursor.