Skip to content

fix: disable context menu in web view mode (SD-1823)#1989

Draft
luccas-harbour wants to merge 4 commits intomainfrom
luccas/sd-1823-superdoc-webpage-mobile-cant-highlightcopy-text
Draft

fix: disable context menu in web view mode (SD-1823)#1989
luccas-harbour wants to merge 4 commits intomainfrom
luccas/sd-1823-superdoc-webpage-mobile-cant-highlightcopy-text

Conversation

@luccas-harbour
Copy link
Contributor

  • On mobile, when the "web" view mode is active, long pressing a word in the editor would trigger the context menu, preventing the user from being able to select text.
  • A change was made so that the context menu is disabled in "web" mode.

@linear
Copy link

linear bot commented Feb 10, 2026

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9cf7271b1b

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

should we add interaction stories for this one?

adding @andrii-harbour here since this can impact eSign

@andrii-harbour
Copy link
Contributor

haven't looked at the code yet, but definitely want to try this SD version with eSign. Will check today

@luccas-harbour luccas-harbour force-pushed the luccas/sd-1823-superdoc-webpage-mobile-cant-highlightcopy-text branch from 7715b1f to 5a1c2e1 Compare February 11, 2026 19:28
@caio-pizzol caio-pizzol self-requested a review February 11, 2026 19:46
Copy link
Contributor

@caio-pizzol caio-pizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@harbournick harbournick added the don't merge Don't merge yet label Feb 13, 2026
@caio-pizzol caio-pizzol self-requested a review February 14, 2026 14:18
@caio-pizzol caio-pizzol marked this pull request as draft February 14, 2026 14:18
@github-actions
Copy link
Contributor

⚠️ AI Risk Review — potential issues found

  • When in web layout, calling setOptions({disableContextMenu: false}) saves false to #disableContextMenuBeforeWebLayout even though the actual option remains true; subsequent switch to print mode may restore incorrect state if user made multiple setOptions calls during web mode

Via L3 deep analysis · sensitive risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments