Repository navigation
Real diagram view type; README with light and dark viewer captures - #8
Merged
Merged
Conversation
…ures
SysON draws every SysML view through one diagram description, so every
diagram's metadata reads "General View". The view type the user chose is
the definition of the ViewUsage SysON creates with the diagram.
- syson_diagram_snapshot returns viewDefinition (read by AQL on the
diagram's ViewUsage; left out when the target is not a typed ViewUsage).
- syson_diagram_create returns the viewUsageId and viewDefinition it
created (ViewUsages listed before and after the creation), and its
description explains the mechanism. The requested type was always
honoured; only the "General View" label suggested otherwise.
- The diagram viewer's eyebrow, current-view line and rendering details
name the real type ("State Transition View").
- README: the Fly action flow in the automatic layout leads the page; a
Viewers section shows the state machine and interconnection captures
side by side and the requirements viewer, each served in light or dark
with the reader's theme. The defensive captions are gone.
- Documentation harness: one fixture per diagram view, ?theme=dark,
?capture (no legend, overview map folded), automatic layout chosen
through the viewer's menu (options carry data-option, toolbar buttons a
per-control class). The capture script drives headless Chrome over the
DevTools protocol and waits for the harness's ready mark, since ELK runs
in a worker that a fixed delay would race.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- tests: the SysON fetch mock is no longer async without await, which
failed `deno task lint` and would have stopped the release job.
- capture script: every DevTools call and the socket opening share the
capture deadline; a closed or failed socket rejects the calls waiting
on it; Chrome exiting before DevTools fails fast; Chrome is stopped
with SIGTERM then SIGKILL, and the temporary profile removal retries.
An explicit FFMPEG_BIN that does not exist is an error again.
- harness: the page is ready only once the viewer shows its title and,
for a diagram, its layout; otherwise it reports data-viewer-error and
the capture fails instead of writing a wrong image.
- syson_diagram_create: the ViewUsage listing never throws after the
creation (a created diagram is never reported as a failure), and when
several ViewUsages appear the one named after the representation wins.
- viewTypeLabel drops SysML name quotes ('Thermal Budget').
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Version 0.9.1 in deno.json, the App manifests (and the bundles that embed them), the server identity test, the README and the getting-started guide; the CHANGELOG entry covers the real diagram view type and the README captures. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SysON draws every SysML view through one diagram description, so every diagram's metadata reads "General View". The view type the user chose is the definition of the ViewUsage SysON creates with the diagram (checked on the live audit project:
StandardViewDefinitions::ActionFlowView,StateTransitionView,InterconnectionView).syson_diagram_snapshotreturnsviewDefinition;syson_diagram_createreturns theviewUsageIdandviewDefinitionit created. The requested type was always honoured; only the "General View" label suggested otherwise.?theme=dark,?capture, automatic layout chosen through the viewer's menu; captures over the DevTools protocol once the viewer is ready (ELK runs in a worker).Verification
deno task fmt,lint,check,ui:check,ui:build,ui:verify: green;deno task test: 274 passed (create/snapshot view definition with a mocked SysON,viewTypeLabel, the three diagram fixture sessions).StandardViewDefinitions::ActionFlowView.🤖 Generated with Claude Code