Fix the worktree ref browse submenu closing on ancestor re-renders - #770
Open
QiushiZhao wants to merge 2 commits into
Open
Fix the worktree ref browse submenu closing on ancestor re-renders#770QiushiZhao wants to merge 2 commits into
QiushiZhao wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
invalid
|
Thanks, this now meets the contribution policy. I've cleared the |
Wrap the native browse Menu in an Equatable value boundary so SwiftUI skips its body while the menu inputs stay equal, preserving an open submenu when agent-presence updates re-evaluate the sheet.
QiushiZhao
force-pushed
the
fix/preserve-open-browse-submenu
branch
from
August 5, 2026 11:46
3983234 to
9b6ca14
Compare
Collaborator
|
I think it's not the equality, though 🤔 |
github-actions
Bot
removed
the
invalid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #771
Summary
The base-ref/upstream browse
Menuin the worktree creation prompt was rebuilt every time the sheet's ancestors re-evaluated (e.g. agent-presence updates), closing an open submenu mid-drill. This wraps the nativeMenuin anEquatablevalue boundary (WorktreeRefBrowseMenu) so SwiftUI skips its body while the menu inputs stay equal, preserving the open submenu. The newWorktreeRefMenuTokencaptures the store-derived values that change the menu's content, keeping the equatable comparison complete.Type of change
How was this tested?
make checkpasses (format + lint)make testpassesFull build could not run on this machine:
make doctorfails preflight because the local Xcode ships the macOS 26.4+ SDK, which the pinned Zig cannot link against (fix: install Xcode 26.3). This is an environment toolchain issue unrelated to the change.make check(format + lint) passes.AI tool disclosure
Checklist
Closes #above.ready.