Repository navigation
refactor: define the role helpers in the prelude - #268
Merged
Merged
Conversation
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-hook-handlers
branch
from
October 29, 2026 12:41
9122ad7 to
13e613b
Compare
Contributor
|
@utkarash2991 looks like this needs to be rebased. |
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-hook-handlers
branch
from
October 29, 2026 22:51
13e613b to
a7b2715
Compare
Base automatically changed from
utkarashsingh/psqlext-1816-hook-handlers
to
master
October 29, 2026 23:01
Move the role helpers from utils.c into pg_prelude.h, above the pragma that blocks the raw lookups. The helpers are then the only code above the pragma, so utils.c no longer needs the opt-out and the raw lookups are blocked everywhere.
utkarash2991
force-pushed
the
utkarashsingh/psqlext-1816-prelude-helpers
branch
from
October 29, 2026 23:06
f6be08a to
cdbd8ca
Compare
steve-chavez
approved these changes
Oct 30, 2026
Member
|
Not sure what happened here but CI has been flaky (ref) on main after this merge. |
Contributor
I think daylight savings time is to blame (not joking) |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #259. The role helpers move from utils.c into pg_prelude.h, above the pragma that blocks the raw lookups. Since the helpers are now the only code above the pragma, utils.c no longer needs the opt-out and the raw lookups are blocked everywhere.