docs: fix inaccurate dartdoc comments across all packages - #1659
Conversation
Audited every dartdoc comment on public API against its actual implementation and corrected mismatches, including stale parameter references, wrong exception types, incorrect defaults, and non-compiling code examples.
|
Warning Review limit reached
Next review available in: 1 minute You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThis PR corrects and expands public API documentation and examples across Supabase Flutter packages. It updates descriptions for request formats, authentication, queries, realtime behavior, storage APIs, client configuration, deep links, and isolate disposal. No runtime code changes are reported. ChangesAPI documentation corrections
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # packages/functions_client/lib/src/functions_client.dart # packages/gotrue/lib/src/gotrue_client.dart # packages/gotrue/lib/src/types/mfa.dart # packages/gotrue/lib/src/types/session.dart # packages/realtime_client/lib/realtime_client.dart # packages/realtime_client/lib/src/realtime_channel.dart # packages/realtime_client/lib/src/retry_timer.dart # packages/realtime_client/lib/src/transformers.dart # packages/supabase_flutter/lib/src/local_storage.dart # packages/supabase_flutter/lib/src/supabase.dart # packages/supabase_flutter/lib/src/supabase_auth.dart
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/gotrue/lib/src/gotrue_client.dart`:
- Around line 1762-1764: Update the documentation near getClaims to state that
JWKS fetching and caching applies to non-HS JWTs only when the token includes a
kid; clarify that RSA tokens without kid use the getUser(token) fallback
instead.
In `@packages/postgrest/lib/src/postgrest_query_builder.dart`:
- Around line 7-13: Update the introductory documentation for
PostgrestQueryBuilder to include upsert() and count() alongside the existing
initial methods, preserving the guidance that each returns a filter builder;
alternatively, change the “Call one of” wording to “For example” if the list is
intentionally non-exhaustive.
In `@packages/postgrest/lib/src/postgrest_rpc_builder.dart`:
- Around line 33-38: Update the documentation comment for the RPC builder method
to describe calls to database functions rather than stored procedures. Document
that when get is true, params must be a Map and the target function must support
read-only execution, while preserving the existing optional-parameter and
read-only access descriptions.
In `@packages/realtime_client/lib/src/transformers.dart`:
- Around line 97-111: Update the `convertColumn` documentation examples to quote
the `name` and `type` map keys in every example, using valid Dart string-key
syntax while preserving the example values and behavior.
In `@packages/supabase_flutter/lib/src/supabase.dart`:
- Around line 84-86: Update the documentation for the debug option in
Supabase.initialize to state that logging is disabled by default during Flutter
tests, while explicitly setting debug to true still enables logging. Keep the
existing kDebugMode default description unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d2eed913-2902-4a18-94d1-0327b3e23eae
📒 Files selected for processing (26)
packages/functions_client/lib/src/functions_client.dartpackages/functions_client/lib/src/types.dartpackages/gotrue/lib/src/gotrue_client.dartpackages/gotrue/lib/src/types/mfa.dartpackages/gotrue/lib/src/types/session.dartpackages/postgrest/lib/src/postgrest_builder.dartpackages/postgrest/lib/src/postgrest_filter_builder.dartpackages/postgrest/lib/src/postgrest_query_builder.dartpackages/postgrest/lib/src/postgrest_rpc_builder.dartpackages/postgrest/lib/src/types.dartpackages/realtime_client/lib/realtime_client.dartpackages/realtime_client/lib/src/realtime_channel.dartpackages/realtime_client/lib/src/realtime_client.dartpackages/realtime_client/lib/src/retry_timer.dartpackages/realtime_client/lib/src/transformers.dartpackages/storage_client/lib/src/iceberg/iceberg_rest_catalog.dartpackages/storage_client/lib/src/storage_bucket_api.dartpackages/storage_client/lib/src/storage_client.dartpackages/storage_client/lib/src/types.dartpackages/supabase/lib/src/realtime_client_options.dartpackages/supabase/lib/src/supabase_client.dartpackages/supabase_common/lib/src/client_info.dartpackages/supabase_flutter/lib/src/local_storage.dartpackages/supabase_flutter/lib/src/supabase.dartpackages/supabase_flutter/lib/src/supabase_auth.dartpackages/yet_another_json_isolate/lib/src/_isolates_io.dart
💤 Files with no reviewable changes (1)
- packages/supabase_flutter/lib/src/local_storage.dart
Clarify that JWKS-based getClaims verification also requires a kid in the JWT header, list the missing upsert() and count() entries in PostgrestQueryBuilder's doc, call rpc() a database function call instead of a stored procedure and note params must be a Map when get is true, quote map literal keys in the transformers.dart examples so they are valid Dart, and correct the debug logging default description for Flutter tests.
Summary
///dartdoc comment on public API across all packages (gotrue, postgrest, storage_client, realtime_client, functions_client, supabase, supabase_common, supabase_flutter, supabase_typegen, yet_another_json_isolate, supabase_lints).Test plan
dart formatrun across all touched packages, no changes neededdart analyzerun on each touched package, no new issues introduced (pre-existing worktree package-resolution noise unrelated to these edits)Summary by CodeRabbit