Skip to content

feat(storage): add the five missing Iceberg catalog capabilities - #76

Merged
spydon merged 1 commit into
mainfrom
feat/iceberg-missing-capabilities-clean
Aug 7, 2026
Merged

feat(storage): add the five missing Iceberg catalog capabilities#76
spydon merged 1 commit into
mainfrom
feat/iceberg-missing-capabilities-clean

Conversation

@spydon

@spydon spydon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Problem

#74 splits the two bundled Iceberg entries into nine per-operation feature IDs: create, list and delete for namespaces; create, list, load, update, rename and delete for tables.

The Iceberg REST Catalog exposes five more operations that no feature ID describes:

Endpoint Proposed ID
GET /namespaces/{ns} storage.analytics.load_namespace_metadata
HEAD /namespaces/{ns} storage.analytics.namespace_exists
POST /namespaces/{ns}/properties storage.analytics.update_namespace_properties
POST /namespaces/{ns}/register storage.analytics.register_table
HEAD /namespaces/{ns}/tables/{table} storage.analytics.table_exists

This is not theoretical. supabase-flutter implements all five today:

IcebergRestCatalog.loadNamespaceMetadata
IcebergRestCatalog.namespaceExists
IcebergRestCatalog.updateNamespaceProperties
IcebergRestCatalog.registerTable
IcebergRestCatalog.tableExists

Because check-api-symbols requires every public symbol to be registered somewhere, and there is no ID that fits, those methods currently have to be declared against a capability they do not implement just to keep CI green. That is visible in supabase/supabase-flutter#1666, where the whole Iceberg symbol list is replicated across every split ID, and in supabase/supabase-flutter#1667, where they sit in a supporting bucket with a comment explaining they have no home.

Splitting a bundled capability into per-verb IDs is only lossless if the verbs cover the surface. These five are the gap.

Change

Adds the five feature IDs to capabilities/storage.yaml, in the existing analytics group, following the descriptions already used for the split entries.

No SDK currently declares anything under storage.analytics, so every SDK except Flutter is unaffected. They stay not_implemented by omission, which is accurate.

Test plan

  • npm run validate: OK — capability matrix is valid.
  • Confirmed against the Iceberg REST Catalog spec that all five are standard catalog endpoints rather than Flutter-specific conveniences.
  • Confirmed supabase-js declares no storage.analytics capabilities, so nothing regresses there.

Related

The Iceberg namespace and table splits cover create, list, load, update,
rename and delete, but the Iceberg REST Catalog exposes five more
operations that no feature id currently describes:

- GET  /namespaces/{ns}            load_namespace_metadata
- HEAD /namespaces/{ns}            namespace_exists
- POST /namespaces/{ns}/properties update_namespace_properties
- POST /namespaces/{ns}/register   register_table
- HEAD /namespaces/{ns}/tables/{t} table_exists

supabase-flutter implements all five today and has nowhere to declare
them, so they end up registered against a capability they do not
implement purely to satisfy the new-symbol check.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@spydon, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d04d96f9-2699-4b33-9b10-9a1e0061a36b

📥 Commits

Reviewing files that changed from the base of the PR and between 9c53a70 and 252190a.

📒 Files selected for processing (1)
  • capabilities/storage.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

spydon added a commit to supabase/supabase-flutter that referenced this pull request Aug 7, 2026
Every Iceberg catalog operation now has a feature id, so loadNamespaceMetadata,
namespaceExists, updateNamespaceProperties, registerTable and tableExists move
out of the top-level supporting bucket into entries of their own. That also
gives RegisterTableRequest and UpdateNamespacePropertiesResult a real owner,
leaving nothing at the top level but genuinely shared types.
@spydon
spydon marked this pull request as ready for review August 7, 2026 09:53
@spydon
spydon requested a review from a team as a code owner August 7, 2026 09:53
@spydon
spydon merged commit c3c8f9e into main Aug 7, 2026
5 checks passed
@spydon
spydon deleted the feat/iceberg-missing-capabilities-clean branch August 7, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants