fix: escape replica_identity_index with ident()#1080
Open
oniani1 wants to merge 1 commit into
Open
Conversation
In tables.update(), replica_identity_index is interpolated into the `REPLICA IDENTITY USING INDEX` clause without ident(), while every other identifier in the same function is escaped. Index names that need quoting produce invalid SQL, and the value is not safely escaped before it reaches the database. Wrap it with ident() to match the surrounding code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tables.update()interpolatesreplica_identity_indexinto theREPLICA IDENTITY USING INDEXclause withoutident(), unlike every other identifier in the same function. Index names that need quoting produce invalid SQL, and the value reaches the database unescaped. This wraps it withident(), matching the rest of the function and thepackages/pg-metasibling.Added a test that updates the replica identity using an index whose name needs quoting. It fails without the change and passes with it.
Closes #1079