Repository navigation
chore: add plpgsql_check to testing - #318
Merged
Merged
Conversation
Closed
AndrewJackson2020
force-pushed
the
plpgsql_check
branch
2 times, most recently
from
October 14, 2026 20:20
ac76d69 to
640deb9
Compare
This was referenced Oct 16, 2026
Contributor
Author
|
Looks like this PR would also have caught an issue on #304 involving an invalid |
AndrewJackson2020
marked this pull request as ready for review
October 21, 2026 21:23
Contributor
Author
|
Setting to "ready for review" as we just did a release on xpg. |
Contributor
Author
|
Went ahead and removed any SQL changes in this PR. Would like to merge #304 before making further SQL changes and would like to merge this first. As is this PR will grandfather in any lint issues flagged and future PR's will fix these. |
AndrewJackson2020
force-pushed
the
plpgsql_check
branch
from
October 22, 2026 15:32
2b86994 to
4ad9478
Compare
steve-chavez
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds plpgsql_check to the pytest suite. It found 1 unused variable and a non returning function. Not critical but still nice to catch stuff like that in a deterministic/systematic way. Would be nice to figure out if there are any other checks that the maintainer would be willing to add that could benefit us here.
Want to hold off on merging this until I can get #304 merged. Also want to see an official xpg bump before merging this. Keeping this in draft until that happens.