fix: update font_awesome_flutter to v11.0.0#152
Open
christianmemije wants to merge 1 commit into
Open
Conversation
3c1647c to
4dbcf10
Compare
|
can we please get this PR done so I dont have to override this project? |
Contributor
|
This repo's been pretty quiet for a year so I'm not sure if you're still around, but if so would you be able to take a look? |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix & compatibility update.
What is the current behavior?
In Flutter 3.24+,
IconDatawas changed to afinalclass. This causes older versions offont_awesome_flutter(< 11.0.0) to fail compilation (exit code 254) because they attempt to extendIconData.Currently,
supabase_auth_uirestrictsfont_awesome_flutterto< 11.0.0and hardcodes its icon implementation to expect standardIconDatatypes, preventing users on modern Flutter from compiling successfully.Fixes #151
What is the new behavior?
font_awesome_flutterdependency to^11.0.0to resolve theIconDatacompile errors.SupaSocialsAuthto useFaIconDataand theFaIcon()widget for rendering social icons, asfont_awesome_flutter11+ no longer returnsIconDatafor its brand icons.Icons.closewithFontAwesomeIcons.xmarkto not use the deprecated icon:'close' is deprecated and shouldn't be used. Use "xmark" insteadAdditional context
Tested on a Flutter 3.44+ where the previous implementation threw an exit code 254 compile error.