Retire vNext transition vocabulary - #1198
Merged
Merged
Conversation
WalkthroughRelay를 유일한 현재 런타임으로 명시했습니다. manifest 기반 lifecycle 설명과 legacy 호환 경로를 제거했습니다. CLI, 검사 로직, capability 계약, 운영 문서 및 스프린트 기록을 Relay 기준으로 갱신했습니다. ChangesRelay 런타임 리셋
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
CI note: the first run had one transient relay-ready concurrent-writer timeout ( |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
tests/relay/scripts/run-preflight.test.js (1)
160-160: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
--manifest폐기에 대한 회귀 테스트를 유지하세요.Line 160의 테스트 삭제로 selector 제거 계약을 직접 검증하는 테스트가 사라집니다.
skills/relay/scripts/run-preflight.jsLine 50의 unknown-flag 경로가--manifest에 대해 실패하는지 확인하는 대체 테스트를 추가하세요. 기대 오류는unknown flags: --manifest와 비제로 종료 상태를 포함해야 합니다.PR 목표의
run-preflight --manifestselector 제거와 변경 범위를 기준으로 판단했습니다.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/relay/scripts/run-preflight.test.js` at line 160, Restore regression coverage for the removed --manifest selector by adding a test alongside the run-preflight CLI tests that invokes the unknown-flag path and verifies --manifest fails with the exact error “unknown flags: --manifest” and a non-zero exit status. Keep the existing mutation audit-reason test unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@backlog/sprints/2026-07-relay-runtime-core-reset-vnext.md`:
- Line 3: Align the sprint completion status with the 4,000–6,000-line dispatch
runtime target in the sprint document. Update the Progress and completion
entries around the status, overall work, and runtime reset to either document
the revised baseline or exception using the current 6,050/6,900 LOC figures, or
remove the completed designation until the target is satisfied.
In `@skills/relay-merge/references/append-learnings.md`:
- Line 3: Update the documentation around append-learnings.js to remove the
misleading “Manifest/fleet owner object” wording. Describe the supported owner
input using the existing valid alias, without implying that finalize-run.js
reads or passes a legacy manifest; keep the documented post-merge flow
unchanged.
---
Nitpick comments:
In `@tests/relay/scripts/run-preflight.test.js`:
- Line 160: Restore regression coverage for the removed --manifest selector by
adding a test alongside the run-preflight CLI tests that invokes the
unknown-flag path and verifies --manifest fails with the exact error “unknown
flags: --manifest” and a non-zero exit status. Keep the existing mutation
audit-reason test unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9605ca8b-9bf5-434a-b5e3-4b022f076015
⛔ Files ignored due to path filters (2)
tests/ledger/vnext-baseline.generated.jsonis excluded by!**/*.generated.*tests/ledger/vnext-test-sites.generated.jsonis excluded by!**/*.generated.*
📒 Files selected for processing (43)
CLAUDE.mdREADME.mdbacklog/sprints/2026-07-relay-runtime-core-reset-vnext.mdbacklog/sprints/2026-08-relay-runtime-slimming.mddocs/README.mddocs/contracts/relay-runtime-inventory.v1.jsondocs/external-tool-workflow.mddocs/relay-lifecycle-manifest-design.mddocs/relay-operator-guide.mddocs/relay-ready-routing-and-handoff-design.mddocs/script-inventory-and-cleanup.mdreferences/architecture.mdreferences/install-graph.mdskills/relay-dispatch/references/recovery-playbook.mdskills/relay-dispatch/scripts/dispatch.jsskills/relay-dispatch/scripts/facts.jsskills/relay-dispatch/scripts/inspect.jsskills/relay-dispatch/scripts/recover.jsskills/relay-fleet/SKILL.mdskills/relay-fleet/references/design.mdskills/relay-fleet/references/sprint-to-leaves.mdskills/relay-fleet/scripts/relay-fleet.jsskills/relay-merge/SKILL.mdskills/relay-merge/references/append-learnings.mdskills/relay-merge/references/legacy-score-reports.mdskills/relay-merge/references/operator-emergencies.mdskills/relay-merge/scripts/finalize-run.jsskills/relay-merge/scripts/gate-check.jsskills/relay-merge/scripts/review-gate.jsskills/relay-plan/references/rubric-patterns.mdskills/relay-plan/references/rubric-simplification.mdskills/relay-plan/references/rubric-trust-model.mdskills/relay-review/SKILL.mdskills/relay-review/references/reviewer-prompt.mdskills/relay-review/references/runner-notes.mdskills/relay-review/scripts/review-runner.jsskills/relay/SKILL.mdskills/relay/references/preflight-guards.mdskills/relay/scripts/relay-status.jsskills/relay/scripts/run-preflight.jsspec/capabilities.mdtests/relay-merge/scripts/gate-check.test.jstests/relay/scripts/run-preflight.test.js
💤 Files with no reviewable changes (1)
- skills/relay-dispatch/scripts/inspect.js
| --- | ||
| milestone: relay-runtime-core-reset-vnext | ||
| status: active | ||
| status: completed |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
완료 상태를 수치 목표와 일치시키세요.
Line 3은 스프린트를 completed로 표시합니다. Line 38과 Line 97-98도 전체 작업과 런타임 리셋의 완료를 기록합니다. 그러나 Line 13의 완료 목표는 4,000–6,000-line dispatch runtime입니다. Line 96은 이미 6,050 LOC를 기록하고, 현재 CLAUDE.md Line 27과 README.md Line 75은 6,900 LOC를 기록합니다. 이 목표가 초기 추정치였다면 변경된 기준 또는 예외를 Progress에 기록하세요. 목표가 완료 조건이면 완료 표기를 수정하거나 수치를 충족해야 합니다.
Also applies to: 38-38, 97-98
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@backlog/sprints/2026-07-relay-runtime-core-reset-vnext.md` at line 3, Align
the sprint completion status with the 4,000–6,000-line dispatch runtime target
in the sprint document. Update the Progress and completion entries around the
status, overall work, and runtime reset to either document the revised baseline
or exception using the current 6,050/6,900 LOC figures, or remove the completed
designation until the target is satisfied.
| # append-learnings.js — post-merge learning writer | ||
|
|
||
| `append-learnings.js` is an explicit post-merge project update. vNext `finalize-run.js` does not invoke it inside the merge transaction. Run it after finalize returns `status: merged`; it writes a one-line entry into the matching capability's `## Learnings` block in the target repo's `spec/capabilities.md`. | ||
| `append-learnings.js` is an explicit post-merge project update. Relay `finalize-run.js` does not invoke it inside the merge transaction. Run it after finalize returns `status: merged`; it writes a one-line entry into the matching capability's `## Learnings` block in the target repo's `spec/capabilities.md`. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
fd -HI -t f 'sprint-owner\.js' skills
rg -n -C 4 '\b[Mm]anifest\b|ownership|sprint-owner' \
skills/relay-merge skills/relay-fleet skills/relay-dispatchRepository: sungjunlee/dev-relay
Length of output: 50378
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the referenced documentation and scripts around ownership resolution
# without executing repository code.
for f in skills/relay-merge/references/append-learnings.md skills/relay-merge/scripts/sprint-owner.js skills/relay-merge/scripts/append-learnings.js; do
echo "=== $f ==="
wc -l "$f"
done
echo "=== append-learnings.md lines 9-15 ==="
sed -n '9,15p' skills/relay-merge/references/append-learnings.md
echo "=== sprint-owner.js lines 1-80, 118-170, 300-370 ==="
sed -n '1,80p' skills/relay-merge/scripts/sprint-owner.js
sed -n '118,170p' skills/relay-merge/scripts/sprint-owner.js
sed -n '300,370p' skills/relay-merge/scripts/sprint-owner.js
echo "=== append-learnings.js lines 350-530 ==="
sed -n '350,530p' skills/relay-merge/scripts/append-learnings.js
echo "=== relevant script usages of readManifestOwnership / resolveSprintOwner ==="
rg -n "readManifestOwnership|resolveSprintOwner|owner:" skills/relay-merge/scripts/sprint-owner.js skills/relay-merge/scripts/append-learnings.jsRepository: sungjunlee/dev-relay
Length of output: 9908
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== sprint-owner.js lines 360-435 ==="
sed -n '360,435p' skills/relay-merge/scripts/sprint-owner.js
echo "=== finalize-run.js append-learnings references ==="
rg -n -C 3 "append-learnings|sprint-owner" skills/relay-merge/scripts/finalize-run.js skills/relay-merge/references/sprint-to-leaves.md 2>/dev/null || true
echo "=== append-learnings.js parseArgs and resolveOwner call ==="
sed -n '240,345p' skills/relay-merge/scripts/append-learnings.js
echo "=== search manifest inputs in relay-merge scripts ==="
rg -n "readFile|readFileSync|manifest|injected|owner:|sprintPath|track|component" skills/relay-merge/scripts/sprint-owner.js skills/relay-merge/scripts/finalize-run.js skills/relay-merge/scripts/append-learnings.jsRepository: sungjunlee/dev-relay
Length of output: 19221
현재 Manifest/fleet owner object 문구를 운영 경로로 제거하세요.
skills/relay-merge/scripts/finalize-run.js는 append-learnings.js를 호출하지 않고 sprint-owner.js는 owner 객체를 받을 수 있지만 전후로 manifest 입력을 읽어들이지 않습니다. 이 표시는 오타처럼 보이고 후속 구현자가 legacy manifest를 다시 넣는 계기로 남을 수 있습니다. 2番 문서에서 Manifest를 제거하거나, 기존 manifest의 유효한 alias를 사용한다고 명확히 기술하세요.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@skills/relay-merge/references/append-learnings.md` at line 3, Update the
documentation around append-learnings.js to remove the misleading
“Manifest/fleet owner object” wording. Describe the supported owner input using
the existing valid alias, without implying that finalize-run.js reads or passes
a legacy manifest; keep the documented post-merge flow unchanged.
Source: Learnings
This was referenced Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
allowMissingVerificationForLegacyProjectionoption andrun-preflight --manifestselectorrun.json, append-only facts, derived actions, and the sole recovery writerWhy
The reset runtime is now the only runtime. Keeping vNext as a current product concept and retaining dead transition selectors made the system look dual-path and obscured real deletion opportunities.
Impact
Runtime baseline decreases from 6,906 to 6,900 LOC and Relay test LOC from 14,848 to 14,838. Dated plans and ADRs remain historical evidence; test/ledger artifact names are intentionally deferred to #1196.
Verification
git diff --check: passFixes #1193
Parent epic: #1197
Summary by CodeRabbit
vNext에서Relay로 통일했습니다.--manifest옵션을 제거했습니다.verification_missing상태를 표시합니다.