Repository navigation
Conversation
…tions page Extract the transaction list into features/transaction-list and reuse it on the bank-account page, scoped to the account with its state in the URL. getMerchants takes an optional accountId so company suggestions are scoped. Fix duplicate group-header keys under the amount sort.
suiramdev
enabled auto-merge (squash)
November 13, 2026 15:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An account's page now has the Transactions page's search and filters, saved filters, Newest/Largest sort and Outgoing/Incoming tabs. Results cover only that account, at every date, and the URL keeps the state. To share the code, the list moved from
pages/budgetinto a newfeatures/transaction-listslice. Look first atfeatures/transaction-list/index.tsandpages/bank-account.Motivation
Drawbacks
shared/ui/list-controls/,shared/ui/{load-error,stale-region},shared/lib/text/amount-boundand a newshared/routingsegment.Prior art
shared/libmodule. Steiger's shared-lib grouping limit is 15, so the URL search helpers went into a newshared/routingsegment instead.Notes
budget.getMerchantsaccepts an optionalaccountId, so company suggestions only list that account's companies.transaction-groups.test.tsgains the duplicate-key case. The period test moved topages/budget/model/period.test.ts.use/home.mdx,reference/procedures.mdx,docs/engineering/web-app.md,docs/engineering/web-ui.md,apps/web/AGENTS.mdand the rootAGENTS.md.upcomingPayments/forecastSeriestests fail in a fullapps/webrun because other test files setTZ. They pass when run alone. This change splits one of thoseTZ-setting test files into two.