Repository navigation
feat(web): animate Kubai icons from their parent button - #280
Merged
Merged
Conversation
suiramdev
enabled auto-merge (squash)
November 13, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every Kubai icon inside a control now animates from the control: hovering or focusing the whole button plays it, and a real change to the button's toggled ARIA state (
aria-pressed,-checked,-selected,-expanded,-current) plays it once. Start withHostAnimatedKubaiIconinapps/web/src/shared/lib/kubai-icon.tsx.Motivation
Drawbacks
kubai-icons, which does not export it.Prior art
trigger="parent"binds hover only and needs adata-kubai-triggerattribute on hosts inside vendored@freenary/uiprimitives; rejected in favour of driving its controlledhoverprop.Notes
apps/fumadocs: none — no page describes icon motion.docs/engineering/web-ui.mdandapps/web/AGENTS.mdupdated.