Open
Conversation
sugarme
reviewed
Feb 14, 2026
Owner
There was a problem hiding this comment.
Why flags for linux would be replaced with those for MacOS? Would be great if we could support both.
Author
There was a problem hiding this comment.
It is going to take me a bit to understand your structure. I think we should support both. I have running go code supporting MPS and CPU as devices at the same time. I will try CUDA as I get the time.
There are a few things in here like this. Once I feel better about how this is done, better from a putting it in not-my-own-thing sense, then it is ok. Until then, there is going to be some back and forth, and I apologize for that now :).
Author
There was a problem hiding this comment.
Please check this now. Any comments are good.
Added a make file as a way to say how to run tests. The pytorch 2.10.0 is local.
Add architecture to make file to allow differences between the repsective ways of doing things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude code to the rescue.
Upgrade from PyTorch 2.1.0 to 2.10.0.
Add MPS for Mac metal.