Fix relationships for markdown headers and footers#7
Open
Bruce-anle wants to merge 2 commits into
Open
Conversation
Background: convert_to_markdown reads word/header*.xml and word/footer*.xml, but passed w:hdr/w:ftr roots to parse_body_to_markdown. That parser only looked for w:body, so header/footer content was skipped.\n\nChanges: allow parse_body_to_markdown to traverse w:hdr and w:ftr roots directly while preserving normal w:document/w:body behavior.\n\nVerification: /home/brucean/doc4agent/.venv/bin/python -m pytest tests -q -p no:cacheprovider passed.
Background: header and footer parts have their own relationship files. The markdown converter parsed header/footer XML but still used document.xml relationships, so header/footer hyperlinks and images could not resolve.\n\nChanges: load word/_rels/header*.xml.rels and word/_rels/footer*.xml.rels while parsing each header/footer part.\n\nVerification: /home/brucean/doc4agent/.venv/bin/python -m pytest tests -q -p no:cacheprovider passed.\n\nNote: this branch is stacked on the header/footer markdown parsing fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Header and footer parts have their own relationship files. Using only word/_rels/document.xml.rels means hyperlinks and images inside headers/footers cannot resolve.
Dependency
This PR is stacked on #5 because header/footer roots must first be converted by the markdown parser. If #5 is merged first, this PR can be rebased to show only the relationship changes.
Tests