Fix disabled run formatting values#2
Open
Bruce-anle wants to merge 1 commit into
Open
Conversation
Background: OpenXML CT_OnOff treats missing w:val as enabled, but explicit 0/false/off as disabled. The markdown converter previously treated w:b, w:i, and w:strike elements as enabled whenever present.\n\nChanges: add CT_OnOff helper for run formatting and tests for enabled and disabled bold, italic, and strikethrough values.\n\nVerification: /home/brucean/doc4agent/.venv/bin/python -m pytest tests -q -p no:cacheprovider passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
DOCX run formatting properties can explicitly disable formatting with w:val="0", "false", or "off". The previous converter treated the element's presence as enabled and emitted incorrect markdown formatting.
Tests