Fix unreachable workers in pings collector NET-384 - #215
Merged
Conversation
A peer's announced listen addrs replace both the Kademlia entry and the address cache, discarding the address the live connection runs on. The test stays red until both stores are fixed. Part of NET-384 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Treating a peer's identify announcement as the authoritative is wrong because sometime workers announce unreachable addresses This reverts commit 292e67f.
kalabukdima
force-pushed
the
address-cache
branch
from
July 30, 2026 13:46
be02c56 to
d905db5
Compare
kalabukdima
changed the title
kalabukdima
marked this pull request as ready for review
August 3, 2026 05:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 292e67f introduced a regression. Pruning the existing cached addresses sometimes drops reachable ones, replacing them with unreachable ones.
The Identify response reports
listen_addrsadvertised by the peer. They may differ from the address the peer was actually dialed on (e.g., the worker manually overwrites the address through the config). In this case, the address from Identify replaces the correct address in both the cache and Kademlia local store. The peer is then not reachable for 20-100 minutes because no reachable addresses are stored for it.In this PR: