Fix incrementEntityViews count; expose user-spaces status filter - #32
Conversation
The server reads `count` from the query string, but it was sent as a body field — so it was ignored and every call incremented the counter by the schema default of 1, whatever amount was passed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The server now accepts a membership status on /spaces/user-spaces, so surface it: "active" (default), "pending" for join requests awaiting approval, or "banned". Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 36 minutes Limit details: You’ve used all 3 included reviews currently available under your plan. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Comment |
Two independent changes.
incrementEntityViewsignored the countThe server reads
countfrom the query string, but the SDK sent it as a body field — so the server never saw it and fell back to its default of 1. Calling withcount: 500incremented the counter by 1.The endpoint is already service/master-key only (
requireElevatedAuth), so this was never client-reachable; it only ever affected backends batching view counts through this SDK.Visible effect: view counts start moving by the real amount. Anything that has been under-counting will look like it jumps.
fetchUserSpacesgains a status filterCompanion to sublay-io/server-hosted#114, which added the param server-side.
"active"(default),"pending"for join requests awaiting approval, or"banned".Testing
Views test rewritten to assert query-param shape, plus a case for the omitted-count path. 418 green.
🤖 Generated with Claude Code