chore: Update PATTERNS.md: change screens.push + pop to be used via Context#283
Open
marceloadsj wants to merge 2 commits into
Open
chore: Update PATTERNS.md: change screens.push + pop to be used via Context#283marceloadsj wants to merge 2 commits into
marceloadsj wants to merge 2 commits into
Conversation
… from inside screen closure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Complement the changes that fixed issue: #279
Updating PATTERNS.md doc to make use of the
ui.push_screen()+ui.pop_screen()in the example whereui.screen()is being used as well.Why
To make sure the sample code shown in the docs compile without errors.
Checklist
Required
cargo fmt -- --checkpassescargo check --all-featurespassescargo clippy --all-features -- -D warningspassescargo test --all-featurespassescargo check --examples --all-featurespassesPublic API Changes
///)widgets.rs, impl onContext, re-export inlib.rsIf Adding a Widget
register_focusable()if interactiveself.theme.*for default colorsIf Applicable
unwrap()in Result-returning functions