Open
Conversation
Izaakwltn
force-pushed
the
fixing-sqrt-bug
branch
from
616e3dc to
533a750
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to fix issue #5
With this (tiny) change,
sqrt-rcan handle very small fractions without throwing an error that they're negative.I checked and it does now calculate the correct sqrt, but I don't know whether the change alters other functions in unpredictable ways.
This PR should probably be dependent on some level of actual test suite being added to CR, which would probably involve checking #3 off the list.