Repository navigation
the shell leaves both headers β a third spelling of the same emoji - #314
Merged
Merged
Conversation
Tyler circled it on his phone: a shell still beside the word "conch" in the ledger header, after #309 had supposedly taken the emoji off every surface that names the app. #309 removed the literal π. Both apps wrote it as `Text("\u{1F41A}")` β the Mac's title strip and the phone's toolbar. A grep for the character cannot see a code point, so the sweep passed and the emoji shipped. The guard written at the time had the same blind spot: `not.toContain("π")` is satisfied trivially by an escape. A sweep for one spelling of a thing is not a sweep for the thing. The guard now checks the CODE POINT across all four surfaces β no source writes it in prose, so that is safe everywhere β and the literal character everywhere except PairingView, whose comment ("The real icon, not the π emoji it replaced") records why that screen dropped the emoji. Deleting the comment to satisfy a sweep would delete the reason. Both comments arguing FOR the shell went with it. One claimed "Same wordmark, same mark, wherever you look at conch" β which is now the opposite of what the code does, and a comment left arguing against its own code is how the `--shRaised` note misled this session for an hour. Kept on purpose: `Image("ConchMark")` on the pairing screen and `ConchMark.statusImage` in the menu bar. Those are the drawn icon, not an emoji, and the menu bar has nothing else to draw. Both are guarded. Verified: bun test 2357/0, tsc clean, swift test 138/0, both apps build. Four mutations, four killed β the escaped shell returning to each header, the wordmark being deleted along with the glyph, and the pairing screen losing its real mark. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tyler circled it on his phone: a shell still sitting beside "conch" in the ledger header β after #309 had supposedly removed the emoji everywhere.
#309 removed the literal
π. Both apps wrote it asText("\u{1F41A}"). A grep for the character can't see a code point, so the sweep passed and it shipped β in both headers.The guard had the same blind spot:
not.toContain("π")is satisfied trivially by an escape sequence.DashboardView.swift:237LedgerView.swift:171PairingView.swift:58Image("ConchMark")β kept, it's the real iconStatusItem.swift:85The guard now covers both spellings
The code point is swept across all four surfaces (no source writes it in prose, so that's safe everywhere). The literal character is swept everywhere except
PairingView, whose comment β "The real icon, not the π emoji it replaced" β records why that screen dropped the emoji. Deleting a comment to satisfy a sweep would delete the reason.Both comments arguing for the shell went with it. One read "Same wordmark, same mark, wherever you look at conch", which is now the opposite of what the code does.
Verified:
bun test2357/0 Β·tscclean Β·swift test138/0 Β· both apps build Β· 4 mutations, 4 killed β including the escaped shell returning to each header.π€ Generated with Claude Code
https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE