Repository navigation
one fleet, one mark: the terminal checks a review too - #310
Merged
Merged
Conversation
#302 moved seven sites in the Mac and iOS apps from a star to a green check, after Tyler: "review ready already has big green check i dont think we also need to bold it." The two terminal surfaces were not in that slice, so the same session showed a star in tmux and a check in both apps. Five sites: the compact header's glyph, `fullStatus`, the panel's REVIEW_GLYPH, the inline deliverable line above a reply, and the comment describing the order. Green because that is what the apps draw — `ConchColor.ready` is #30B35A, and the lab's `--ready` is the same. The star's `\x1b[33m` was yellow. Fifteen assertions pinned the star across status.test and panel.test. Every one of their claims is "a review-ready row is marked"; the glyph was incidental, so the literals moved and the claims did not. NOT changed, and reported instead: the terminal contradicts ITSELF about the waiting colour. `status.ts` paints it yellow in the compact header (guarded, with a comment: "waiting is now yellow — a finished turn is sitting on you") and green in `fullStatus`; `panel.ts` paints it green. That is three sites and a state- language decision, not a review fix, so it stays Tyler's call. Verified: bun test 2345/0, tsc clean, swift test 138/0. Seven mutations, seven killed — including two that matter more than the others. Deleting snippet.ts's stripping range killed the speech test, so that test measures behaviour rather than passing vacuously. Drifting the Mac app back to `star.fill` killed the cross-surface test, so the apps are held, not merely described. The audible failure mode was checked by running it, not by reading the regex: `speakable("✓ needs review")` returns "needs review". Nothing reads the glyph into your ear. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#302 moved the Mac and iOS apps from a star to a green check. The terminal wasn't in that slice, so the same session showed a star in tmux and a check in both apps.
status.ts:361compact header glyph\x1b[33m⭐\x1b[32m✓status.ts:446full status⭐ needs review✓ needs reviewstatus.ts:780inline deliverable⭐ ${summary}✓ ${summary}panel.ts:825REVIEW_GLYPH⭐ needs review✓ needs reviewGreen because that's what the apps draw —
ConchColor.readyis#30B35A, the lab's--readyis the same, and the star's\x1b[33mwas yellow.Fifteen assertions pinned the star across
status.test/panel.test. Every claim was "a review-ready row is marked" — the glyph was incidental, so the literals moved and the claims didn't.Checked by running it, not by reading it
The failure mode here is audible: if the glyph isn't stripped, conch reads "check needs review" into your ear.
speakable("✓ needs review")→"needs review". And deletingsnippet.ts's stripping range kills that test, so it measures behaviour rather than passing vacuously.Reported, not fixed
The terminal contradicts itself about the waiting colour:
status.tspaints it yellow in the compact header (guarded, with "waiting is now yellow — a finished turn is sitting on you") and green infullStatus;panel.tspaints it green. Three sites, a state-language decision, and not a review fix — so it's yours to call.Verified:
bun test2345/0 ·tscclean ·swift test138/0 · 7 mutations, 7 killed — including one that drifts the Mac app back tostar.fill, proving the cross-surface agreement is held rather than merely described.🤖 Generated with Claude Code
https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE