Repository navigation
mac: the header, px for px against the lab - #300
Merged
Merged
Conversation
Three corrections, each taken from `workspace-lab.html`'s own CSS rather than
§3's prose — the prototype is what "matches the mockups" means.
The session title is the line that says what you are looking at, and it was
12.5 medium: a size the header's own meta text could match. `.ttl{font:600
14px;letter-spacing:-.01em}`.
Context pressure becomes `.ctxwarn` — a percentage, not a running token tally,
and drawn only at 85% and above (§5: "87% context"). Below that the header
says nothing about it at all, which is Tyler's own complaint ("a lot of
importance to a not super important piece of data") carried further than
colour alone could carry it. `used / limit` survives where it is asked for,
in the tooltip and to VoiceOver. The third status colour went with the rows
the meter used to sit on, so the branch that painted it is gone.
The view switch becomes `.seg`: one track on `--fill` at 2pt padding, 8pt
radius and 1pt gaps, each segment 30x24 at radius 6, the selected one marked
by `--fillSel` and nothing else. Three loose buttons read as three unrelated
controls; one track with a filled position reads as one control that knows
where it is. `.seg button.on` also asks for `box-shadow:var(--shRaised)`, a
variable defined nowhere in the lab and therefore rendering nothing — so the
fill is the whole mark, exactly as the prototype shows it.
The breadcrumb and the state-text chip are deliberately NOT here: they need a
state vocabulary the app does not have (the lab's `VIS`), and a px pass is the
wrong place to invent one.
Gated: bun test 2309/0, tsc clean, swift test 131/0, Mac and iOS both build
(CI builds neither). Nine mutations across all three corrections, nine killed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE
Owner
Author
|
Correction, found while sourcing the next slice:
My earlier grep missed it because the lab defines its whole palette on one minified line, and I searched for the variable at the start of a line. So Being fixed in the next slice alongside the The three px corrections in this PR (title, context meter, seg geometry) are unaffected — they were sourced from the CSS directly. |
stupart
added a commit
that referenced
this pull request
Sep 16, 2026
`--shRaised` IS defined in the lab — line 17, and line 20 for dark. The grep behind the claim that it wasn't looked for the variable at the start of a line, and the lab's `:root` is minified onto one. So #300 shipped the selected segment flat AND added a guard asserting it stay that way. Both are corrected here; the guard is inverted rather than deleted, so the mistake cannot return quietly. Reading the whole table turned up the second divergence, which #299 introduced: the stage panel borrowed `.raised`, and `ElevationModifier` doubled every shadow on dark. The lab's `--shPanel` keeps its ring and drops its shadow outright on dark — something no blanket rule can express. Each level now carries the lab's own pair, and `panel` becomes its own level: light dark --shPanel r1.5 y1 .04 ring only, no drop --shRaised r1 y1 .14 r1 y1 .4 --shFloat r14 y10 .24 r14 y10 .7 --shOver r32 y24 .32 r32 y24 .75 CSS blur is twice SwiftUI's shadow radius. Two more were wrong on the way past: `.overlay` sat at r24/y18/.26 against the lab's r32/y24/.32, and `.floating` computed .44 on dark where the lab asks .7. Elevation had no test coverage whatsoever. It has seven tests now, including a pixel test of the modifier itself — every value test still passes with the doubling rule in place, so the values alone could never catch its return. The segment's hover fill is recorded as the app's own: the lab gives `.seg button` no `:hover` rule at all. Gated: bun test 2309/0, tsc clean, swift test 138/0, Mac and iOS both build (CI builds neither). Twelve mutations across the tokens, the modifier and the source guards; twelve killed. Claude-Session: https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header's three fully-sourced corrections, each quoted to the lab selector it came from.
.ttl{font:600 14px;letter-spacing:-.01em}used / limit, always87% context, at ≥85% only.ctxwarn{font-size:12px;color:var(--listening)}+ §5.segtrack.seg{padding:2px;border-radius:8px;background:var(--fill);gap:1px}The selected segment is marked by
--fillSelalone:.seg button.onalso asks forbox-shadow:var(--shRaised), but that variable is defined nowhere in the lab, so it renders nothing in the prototype either.Two deletions fall out of the threshold change: the meter's third status colour (unreachable once it is not drawn below 85%) and
PerspectiveOption's old padding/height, which would fight the fixed 30×24 frame.Not in this slice, on purpose: the breadcrumb and the state-with-text chip. Both need the lab's
VISstate vocabulary, which the app does not have — and a px pass is the wrong place to invent one.Gate:
bun test2309/0 ·tscclean ·swift test131/0 · Mac + iOSxcodebuildboth green (CI builds neither app) · 9 mutations, 9 killed.🤖 Generated with Claude Code
https://claude.ai/code/session_01SfEX6bfwCGXtThk1JRNmsE