Skip to content

Add (or rename) a LargeText component variant to explicitly support HTML elements #71

Description

@KeziahMoselle

Why

The name LargeText means it is supposed to only be used with text.
There is cases where we need to use this kind of animation for blocks elements and we are using this component to do so but the API of the component doesn't allow us to easily do what we want and requires overrides.

When used this way it also wraps blocs element in a <span> element, which is incorrect semantically.

<div {{ html_attributes(attributes) }}>
  <span {{ html_attributes(target_attributes) }}>
    {% for count in 1..repeat ?? 2 %}
      ...
    {% endfor %}
  </span>
</div>

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions