Env var improvements - #4
Open
2-shell wants to merge 2 commits into
Open
Conversation
added 2 commits
January 8, 2023 23:39
Moving the env var definitions into the Dockerfile makes it IMHO clearer that these variables are in fact part of the image's "API". This also enables discovering the vars with `docker inspect`, without looking into the image's entrypoint script. Another side effect is, that we can avoid code duplication of default values (e.g. port). This is not a big deal, but could help with future additions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the env var definitions into the Dockerfile would make it IMHO clearer that these variables are in fact part of the image's "API".
This also enables discovering the vars with
docker inspect, without looking inside the image and find its entrypoint script.Another side effect is, that we can avoid code duplication of default values (e.g. port).
This is currently not a big deal, but could help with future additions.
This is of course subjective and I totally understand if you would rather keep things like they are, so this is just a suggestion.