Compressible two fluid model - #337
Open
szekedidavid wants to merge 77 commits into
Open
Conversation
…rything that entails
…-hub/struphy into refactor-two-fluid-model
…rything that entails
…g test case in 2D satisfies BCs, but blows up in the interior.
…e for lifting reconstruction.
…uphy into refactor-two-fluid-model
Redo of #25 See corresponding PR in feectools here: struphy-hub/feectools#74 Notes: This MR is still pointing towards `318`, but it will be merged into devel once finished (which will be after 318 has already been merged). To run on my PC, I still need to do: ``` export ARRAY_BACKEND=cupy export CUDA_PATH=/usr/local/cuda export PATH=$CUDA_PATH/bin:$PATH ``` I am then running the Vlasov standard parameters ``` struphy params Vlasov -y python params_Vlasov.py ``` To do - [ ] Fix the need for setting CUDA path - [ ] We have many cases of `from numpy import xyz`, this makes sense in pyccelized kernels since we will not be allowed to use cupy there. But in my current testing, but otherwise not. - [ ] When calling a pyccelized kernel while using cupy, we can convert the arrays to numpy arrays, they should also be converted back to cupy arrays afterwards. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: max-models <181350288+max-models@users.noreply.github.com>
…rmal trace integral.
…uphy-hub/struphy into compressible-two-fluid-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.